Java: Add value predicates for float and double literals; improve tests #5468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marcono1234
commented
Mar 21, 2021
| @@ -653,11 +653,23 @@ class LongLiteral extends Literal, @longliteral { | |||
|
|
|||
| /** A floating point literal. For example, `4.2f`. */ | |||
| class FloatingPointLiteral extends Literal, @floatingpointliteral { | |||
| /** | |||
| * Gets the value of this literal as CodeQL 64-bit `float`. The value will | |||
| * be parsed as Java 32-bit `float` and then converted to a CodeQL `float`. | |||
There was a problem hiding this comment.
Added this clarify how a value which is not a precise Java float, e.g. 1.55555555555f, will be parsed.
That is, it will have the value 1.5555556 and not 1.55555555555 (which could be represented using CodeQL's float).
| override string getAPrimaryQlClass() { result = "FloatingPointLiteral" } | ||
| } | ||
|
|
||
| /** A double literal. For example, `4.2`. */ | ||
| class DoubleLiteral extends Literal, @doubleliteral { | ||
| /** | ||
| * Gets the value of this literal as CodeQL 64-bit `float`. The result will | ||
| * have the same effective value as the Java `double` literal. |
There was a problem hiding this comment.
Added this to clarify how values which are not precise Java doubles respectively CodeQL floats will be parsed.
That is, for example 1.55555555555555555555d which is effectively 1.5555555555555556d will also have that as result of this predicate.
| }; | ||
|
|
||
| String[] strings = { | ||
| "hello" + "world", // two separate literals |
There was a problem hiding this comment.
This is currently erroneously detected as one StringLiteral, see #5469.
aschackmull
approved these changes
Mar 22, 2021
aschackmull
added
the
no-change-note-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the predicates:
FloatingPointLiteral.getFloatValue()DoubleLiteral.getDoubleValue()Improves existing literal tests.