Python: Ensure first type-tracking predicate is private #5504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it's exposed nicely in the version that doesn't have a `DataFlow::TypeTracker` parameter, these should be private. Also found one instance where I had accidentially used DataFlow::Node instead of LocalSourceNode
yoff
previously approved these changes
Mar 24, 2021
Hmm 🤔 I think if you want to follow our deprecation policies to the letter, I guess you could argue that these predicates have been public for long enough that you can't just remove them... From my point of view, that is too pedantic, since none of these predicates offers any additional value compared with their variants without TypeTracking parameter. In this situation, I think our ability to fix our code-base outweighs the downside from not following our deprecation policy to the letter. |
|
I agree. Each of these is an internal helper predicate used to define an external predicate of the same name. It makes little sense to use them directly. |
|
Ship to learn, then.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the tests might not have been too important, but ensures we have a consistent use throughout our codebase 😊