Skip to content

JS: recognize headers/url from the HTTP request to a server WebSocket. #5529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

erik-krogh
Copy link
Contributor

@erik-krogh erik-krogh commented Mar 25, 2021

An evaluation looks good.
The new log-injection result looks good.
But I don't know why the other new results appeared.

@github-actions github-actions bot added the JS label Mar 25, 2021
@erik-krogh erik-krogh added the Awaiting evaluation Do not merge yet, this PR is waiting for an evaluation to finish label Mar 25, 2021
@erik-krogh erik-krogh removed the Awaiting evaluation Do not merge yet, this PR is waiting for an evaluation to finish label Apr 6, 2021
@erik-krogh erik-krogh marked this pull request as ready for review April 6, 2021 22:43
@erik-krogh erik-krogh requested a review from a team as a code owner April 6, 2021 22:43
@erik-krogh erik-krogh added the no-change-note-required This PR does not need a change note label Apr 6, 2021
@esbena
Copy link
Contributor

esbena commented Apr 7, 2021

LGTM

But I don't know why the other new results appeared.

Hmm. https://github.com/github/codeql-dca/issues/79

@esbena
Copy link
Contributor

esbena commented Apr 7, 2021

Lets wait for an investigation of github/codeql-dca#79 before we merge this.

@codeql-ci codeql-ci merged commit f0491af into github:main Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JS no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants