Skip to content

Python: Revert #5506 due to bad performance #5552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2021
Merged

Python: Revert #5506 due to bad performance #5552

merged 2 commits into from
Mar 31, 2021

Conversation

RasmusWL
Copy link
Member

The #5506 PR caused performance problems, so reverting now to clear up immediate problems.

@RasmusWL
Revert "Merge pull request github#5506 from tausbn/python-allow-absol…
92e0e19 
…ute-imports-from-source-directory"

This reverts commit 8d15680, reversing
changes made to 63831cc.

This PR caused performance problems, so reverting now to clear up immediate
problems.
@RasmusWL RasmusWL requested a review from a team as a code owner March 29, 2021 08:42
@RasmusWL RasmusWL added the no-change-note-required This PR does not need a change note label Mar 29, 2021
@RasmusWL
Copy link
Member Author

Performance test shows that this PR does indeed solve the problem, when running against last successful commit from main: https://github.com/dsp-testing/RasmusWL-dca/tree/run/R-702660685/reports

(that is, the a43bb1f commit part comes from https://jenkins.internal.semmle.com/job/Changes/job/Python-Differences/490/parameters/)

@calumgrant calumgrant merged commit 49d1937 into github:main Mar 31, 2021
@RasmusWL RasmusWL deleted the revert-import-change branch March 31, 2021 08:52
tausbn added a commit to tausbn/codeql that referenced this pull request Apr 6, 2021
@tausbn
Revert "Merge pull request github#5552 from RasmusWL/revert-import-ch…
8e11abc 
…ange"

This reverts commit 49d1937, reversing
changes made to d4877a9.
@tausbn tausbn mentioned this pull request Apr 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@calumgrant calumgrant calumgrant approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RasmusWL @calumgrant