-
Notifications
You must be signed in to change notification settings - Fork 1.8k
JS: Add model of pg-promise #5553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Impressive numbers!
Subjective module structuring:
What do you think of splittling the Postgres
module into two internal modules Postgres::pg
and Postgres::pg-promise
to avoid the explicit mention of pg-promise
in all of the docstrings?
Types
pg-promise
has types, can we add the ofType
cases to this PR, like we do for our related mongodb
/mongoose
models?
result = API::Node::ofType("mongoose", "Model") |
Co-authored-by: Esben Sparre Andreasen <esbena@github.com>
I don't think it's a huge problem to mention
👍 |
@@ -0,0 +1,13 @@ | |||
import { IDatabase } from "pg-promise"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this file belongs to the typed
directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The typed
directory is for tests that rely on type information provided by the TypeScript compiler, which in turn requires a .d.ts
shim.
As of #4401, however, we don't need that in our tests anymore, which is why the test works in this directory.
Adds a model of pg-promise, a PostgreSQL connector library.
Evaluations: (internal link)