JS: Make SourceNode and PropRef.getBase non-recursive, again #5554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SourceNode
non-recursive (really, this time)PropRef.getBase
non-recursive by fixing an accidental reference toSourceNode
PropRef.getBase
Although #5499 was supposed to make
SourceNode
non-recursive, I had missed one recursive dependency going throughSourceNode -> AngularJS -> Import -> NodeJS/createRequire -> SourceNode
. My earlier attempt in #4772 fixed that by making all string literalsSourceNode
but that was a little too costly, so now I've instead madecreateRequire
not depend onSourceNode
.Evaluation (internal link) looks good; an average 1% speed-up and a <1% increase is cache size.