Replace toString use #5558
Merged
Replace toString use #5558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevinbackhouse this is a small modification to a query we had been discussing. Can you spare a couple of minutes to review it? (if not I'll ask someone in the CPP team) |
MathiasVP
reviewed
Mar 31, 2021
...l/src/experimental/Security/CWE/CWE-570/WrongInDetectingAndHandlingMemoryAllocationErrors.ql
Outdated
Show resolved
Hide resolved
…ndHandlingMemoryAllocationErrors.ql Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com>
kevinbackhouse
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
toStringin query logic is not good practice.These kinds of changes can have subtle effects so I've run a diff query: https://lgtm.com/query/5866409770224514073/ .
I think the new results (beginning on page 3) are for calls to a 'non-allocating' new (see https://en.cppreference.com/w/cpp/memory/new/operator_new), that is
nothrownot because it returns0on an allocation error, but because it doesn't have allocation errors. If someone can confirm this makes sense, I'll add an exclusion in the query for that version ofnew.The lost results (on page 4) LGTM.