Skip to content

Make stronger recommendations around the use of the lgtm.com branch #5563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 29, 2021

Conversation

lecoursen
Copy link
Member

@lecoursen lecoursen commented Mar 29, 2021

This PR closes the linked issue by explicitly calling out the following use cases for the lgtm.com branch:

  • You've built a database using the CodeQL CLI.
  • You've fetched a database from Code Scanning.

@lecoursen lecoursen marked this pull request as ready for review March 29, 2021 17:47
shati-patel
shati-patel previously approved these changes Mar 29, 2021
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this clarification, @lecoursen

I've left a small suggestion, but this looks good otherwise!

Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
@lecoursen lecoursen requested a review from shati-patel March 29, 2021 19:10
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to merge :shipit:

@lecoursen lecoursen merged commit 2dadc75 into github:main Mar 29, 2021
@lecoursen lecoursen deleted the stronger-rec-to-use-lgtm.com-branch branch March 29, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants