C#: HttpOnly and Secure cookie queries #5579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
as a 
ghost
mentioned this pull request
tamasvajk
suggested changes
Apr 12, 2021
There was a problem hiding this comment.
Thank you for this contribution. I've added some comments inline. Also, can I ask you to merge the similar checks to Require HttpOnly and Require SSL respectively? I think it would be a lot cleaner for an end-user to have a single check than having 4 seperate queries:
- httponly is set to false in asp.net
- httponly is set to false in asp.net core
- httponly is not set, and therefore has its default value false in asp.net
- httponly is not set, and therefore has its default value false in asp.net core
for different variations of the same vulnerability.
csharp/ql/src/experimental/Security Features/CWE-1004/CookieHttpOnlyFalseAspNetCore.qhelp
Outdated
Show resolved
Hide resolved
csharp/ql/src/experimental/Security Features/CWE-1004/CookieHttpOnlyFalseSystemWeb.qhelp
Outdated
Show resolved
Hide resolved
csharp/ql/src/experimental/Security Features/CWE-1004/CookieWithoutHttpOnlyAspNetCore.qhelp
Outdated
Show resolved
Hide resolved
csharp/ql/src/experimental/Security Features/CWE-1004/CookieWithoutHttpOnlyAspNetCore.ql
Outdated
Show resolved
Hide resolved
csharp/ql/src/experimental/Security Features/CWE-1004/CookieWithoutHttpOnlySystemWeb.ql
Outdated
Show resolved
Hide resolved
csharp/ql/src/semmle/code/csharp/dataflow/flowsources/AuthCookie.qll
Outdated
Show resolved
Hide resolved
|
I thought it would be easier to maintain and drop legacy .NET queries when needed. Anyway, here we go - single queries. |
|
Ping |
tamasvajk
suggested changes
Apr 27, 2021
csharp/ql/src/semmle/code/csharp/dataflow/flowsources/AuthCookie.qll
Outdated
Show resolved
Hide resolved
csharp/ql/src/semmle/code/csharp/dataflow/flowsources/AuthCookie.qll
Outdated
Show resolved
Hide resolved
csharp/ql/src/experimental/Security Features/CWE-614/CookieWithoutSecure.ql
Show resolved
Hide resolved
csharp/ql/src/semmle/code/csharp/frameworks/microsoft/AspNetCore.qll
Outdated
Show resolved
Hide resolved
|
Is there anything I need to do? |
hvitved
reviewed
Jun 16, 2021
added 15 commits
July 12, 2021 01:13
…s already covered by higher level `exists`
|
Rebased the pull request on top of main. Only the the last two commits are new. Please review. |
hvitved
previously approved these changes
Jul 14, 2021
|
Ping |
|
|
hvitved
approved these changes
Aug 5, 2021
tamasvajk
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks
Securecookie detection for asp.net. AddsHttpOnlyattribute check. Adds both attributes and various callbacks and policy settings support for asp.net core.