Java: Add ToStringMethod #5637
Merged
Java: Add ToStringMethod #5637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschackmull
approved these changes
Apr 9, 2021
aschackmull
requested changes
Apr 9, 2021
Marcono1234
force-pushed
the
marcono1234/toString-method
branch
from
b88a650 to
9349e69
Compare
Marcono1234
commented
Apr 10, 2021
| e = ma.getQualifier() and | ||
| toString.getName() = "toString" and | ||
| toString.getNumberOfParameters() = 0 and | ||
| not toString.isStatic() |
There was a problem hiding this comment.
Removed this check because it does not seem possible to declare a static toString() method.
aschackmull
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often queries check for a
toString()method, however previously there was no built-in CodeQL class for this.This pull request adds
ToStringMethodtoJDK.qll.