Java: CWE-1004 Query to check sensitive cookies without the HttpOnly flag set w/minor corrections #5663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test ought ideally to be caught, but isn't by the current version of the query.
By removing all business logic from the stubs, we better test that our analysis treats them as opaque and does not rely on their internal structure
aschackmull
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #5307 plus two minor cleanups: commenting on a test that ought to be flagged but the current query isn't accurate enough to catch, and removing private fields / constructor logic from stubs. Will self-merge since this is 99% luchua-bc's work that I'm reviewing, and entirely targets experimental apart from adding some stubs to already-partly-stubbed libraries, which are themselves in ql/test/stubs.