Python: Disallow PostUpdateNode as LocalSourceNode
#5690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, in cases like
```python
def foo(x):
x.bar()
x.baz()
x.quux()
```
we would have flow from the first `x` to each use _and_ flow from the
post-update node for each method call to each subsequent use, and all
of these would be `LocalSourceNode`s. For large functions with the above
pattern, this would lead to a quadratic blowup in `hasLocalSource`.
With this commit, only the first of these will count as a
`LocalSourceNode`, and the blowup disappears.
tausbn
added
Awaiting evaluation
|
Hmm... Test failures seem to indicate that having |
Specifically, allow the ones arising from calls, but not reads or writes. This should fix the tests.
|
Performance: https://github.com/dsp-testing/tausbn-dca/issues/13 |
tausbn
removed
the
Awaiting evaluation
Goes into some detail about the intended semantics of local source nodes and `flowsTo`.
tausbn
added
the
Awaiting evaluation
|
As the behaviour has now changed since the last performance test, I'm running another one. |
yoff
reviewed
Apr 16, 2021
|
Evaluation (still) running here: https://github.com/dsp-testing/tausbn-dca/issues/14 |
tausbn
removed
the
Awaiting evaluation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, in cases like
we would have flow from the first
xto each use and flow from thepost-update node for each method call to each subsequent use, and all
of these would be
LocalSourceNodes. For large functions with the abovepattern, this would lead to a quadratic blowup in
hasLocalSource.With this commit, only the first of these will count as a
LocalSourceNode, and the blowup disappears.Evaluation needed. I don't think a change note is necessary (but I'm willing to be convinced otherwise).