Skip to content

JS: Add taint source/sink summary queries #5728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 11, 2021
Merged

JS: Add taint source/sink summary queries #5728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f8a9b9
JS: Add taint source/sink summary queries
asgerf Apr 20, 2021
02707f0
JS: informational -> info
asgerf Apr 20, 2021
df5eab3
JS: Update relevantTaintSource()
asgerf May 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions javascript/ql/src/Summary/TaintSinks.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
/**
* @name Taint sinks
* @description Expressions that are vulnerable if containing untrusted data.
* @kind problem
* @problem.severity info
* @id js/summary/taint-sinks
* @tags summary
* @precision medium
*/

import javascript
import meta.internal.TaintMetrics

from string kind
select relevantTaintSink(kind), kind + " sink"
16 changes: 16 additions & 0 deletions javascript/ql/src/Summary/TaintSources.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
/**
* @name Taint sources
* @description Sources of untrusted input.
* @kind problem
* @problem.severity info
* @id js/summary/taint-sources
* @tags summary
* @precision medium
*/

import javascript
import meta.internal.TaintMetrics

from RemoteFlowSource node
where node = relevantTaintSource()
Comment on lines +14 to +15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relevantTaintSource has return-type DataFlow::Node, so I think the node here should have that type.

Suggested change
from RemoteFlowSource node
where node = relevantTaintSource()
from DataFlow::Node node
where node = relevantTaintSource()

Or relevantTaintSource could be changed to have the return-type RemoteFlowSource.
DOM::locationSource() is a RemoteFlowSource anyway, so relevantTaintSource could be simplified in the same go.

select node, node.getSourceType()
11 changes: 2 additions & 9 deletions javascript/ql/src/meta/internal/TaintMetrics.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,16 +75,9 @@ DataFlow::Node relevantTaintSink(string kind) {
DataFlow::Node relevantTaintSink() { result = relevantTaintSink(_) }

/**
* Gets a remote flow source or `document.location` source.
* Gets a relevant remote flow source.
*/
DataFlow::Node relevantTaintSource() {
not result.getFile() instanceof IgnoredFile and
(
result instanceof RemoteFlowSource
or
result = DOM::locationSource()
)
}
RemoteFlowSource relevantTaintSource() { not result.getFile() instanceof IgnoredFile }

/**
* Gets the output of a call that shows intent to sanitize a value
Expand Down