Python: Limit absolute imports #5791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limits the behaviour of github#5614 in two ways: First, we only consider files that are contained in the source archive. This prevents unnecessary computation involving files in e.g. the standard library. Secondly, we ignore any relative imports (e.g. `from .foo import ...`), as these only work inside packages anyway. This fixes an observed performance regression on projects that include `google-cloud-sdk` as part of their source code.
tausbn
added
Awaiting evaluation
|
Hmm... I had hoped this limiting of absolute imports would be all that was required, but it seems that evaluation of the MRO is slow even with this change. I guess I'll be adding a few more improvements to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limits the behaviour of #5614 in two ways:
First, we only consider files that are contained in the source archive.
This prevents unnecessary computation involving files in e.g. the
standard library.
Secondly, we ignore any relative imports (e.g.
from .foo import ...),as these only work inside packages anyway.
This fixes an observed performance regression on projects that include
google-cloud-sdkas part of their source code.As with #5614, I don't think a change note is required.