Skip to content

C#: Always pass /p:UseSharedCompilation=false to dotnet build in auto builder #5882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 17, 2021
Merged

C#: Always pass /p:UseSharedCompilation=false to dotnet build in auto builder #5882

merged 2 commits into from
May 17, 2021

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented May 12, 2021

Until we have a proper (tracer based) fix for this, we may as well disable shared compilation when invoking dotnet build from the auto builder.

@hvitved hvitved requested a review from a team as a code owner May 12, 2021 08:17
@github-actions github-actions bot added the C# label May 12, 2021
@hvitved
Copy link
Contributor Author

hvitved commented May 12, 2021

Tested here: https://jenkins.internal.semmle.com/job/Changes/job/CSharp-Differences/1065/.

tamasvajk
tamasvajk reviewed May 17, 2021
View reviewed changes
@hvitved hvitved merged commit ae6326b into github:main May 17, 2021
@hvitved hvitved deleted the csharp/autobuilder/shared-compilation branch May 20, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@tamasvajk tamasvajk tamasvajk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@tamasvajk tamasvajk

Labels
C#
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvitved @tamasvajk