JS: Use the new non-extending-subtypes syntax #5888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
changed the title
asgerf
previously approved these changes
Sep 10, 2021
| @@ -826,7 +826,7 @@ module NodeJSLib { | |||
| * for example `http.request(url)`. | |||
| */ | |||
| class NodeJSClientRequest extends ClientRequest { | |||
| override NodeJSClientRequest::Range self; | |||
| NodeJSClientRequest() { this instanceof NodeJSClientRequest::Range } | |||
There was a problem hiding this comment.
Is there a reason we can't use instanceof in the base type here?
There was a problem hiding this comment.
I suppose not.
ClientRequest is already instance of the ::Range pattern, so I suppose I didn't want to introduce "nested" ::Range patterns.
But it should just work, so I've changed it.
asgerf
approved these changes
Sep 10, 2021
|
Is this comment (and similar ones) still correct?
|
Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I grepped through the JavaScript QL for
::Range, and first I converted them all to the casting-based::Rangepattern, and next to the new syntax.I think I got most, but I might have missed some.
Evaluation looks fine.
(No noticeable performance change, no change in results).
/cc @ginsbach