C++: Add range analysis to cpp/static-buffer-overflow
#5923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a PR check failure asking for a change note. |
Thanks for the heads up. Fixed in 6103aab. |
rdmarsh2
reviewed
May 18, 2021
| // result in this case we pick the minimum value obtainable from dataflow and range analysis. | ||
| result = | ||
| upperBound(statedSizeExpr()) | ||
| .minimum(any(Expr statedSizeSrc | |
There was a problem hiding this comment.
Should we be using the min aggregate here, rather than int::minimum and any?
There was a problem hiding this comment.
Good point. Fixed in 741eed9.
… min aggregate further down since it's no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Part of https://github.com/github/codeql-c-analysis-team/issues/191.)
This PR uses range analysis to filter out false positives in 2 out of the 3 kinds of problems identified by
cpp/static-buffer-overflow.It does remove a couple of false positives on our usual list of LGTM projects: https://lgtm.com/query/3164577302384476236/. Hopefully, once this PR is merged, we can see what the next class of low-hanging fruit is after the next LGTM upgrade.