Skip to content

C#: Encode " in BuildDisplayName #5947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2021
Merged

C#: Encode " in BuildDisplayName #5947

merged 1 commit into from
May 25, 2021

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented May 23, 2021 •
edited
Loading

Apparently, compiler-generated type names may contain ", so we need to escape these before writing to TRAP.

@hvitved hvitved requested a review from a team as a code owner May 23, 2021 12:47
@github-actions github-actions bot added the C# label May 23, 2021
@hvitved hvitved assigned tamasvajk and hvitved and unassigned tamasvajk and hvitved May 25, 2021
@hvitved hvitved merged commit 8cbb3ca into github:main May 25, 2021
@hvitved hvitved deleted the csharp/encode-display-name branch May 25, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@tamasvajk tamasvajk tamasvajk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@tamasvajk tamasvajk

Labels
C#
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvitved @tamasvajk