Skip to content

Java: Move common CSV logic for sources and sinks into shared library #5991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 4, 2021
Merged

Java: Move common CSV logic for sources and sinks into shared library #5991

merged 3 commits into from
Jun 4, 2021

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Jun 2, 2021 •
edited
Loading

@hvitved hvitved force-pushed the java/shared-external-source-sink branch 4 times, most recently from 49ec1c5 to 5bffb6f Compare June 3, 2021 08:49
@hvitved hvitved force-pushed the java/shared-external-source-sink branch from 5bffb6f to cc02c95 Compare June 3, 2021 11:55
@hvitved hvitved marked this pull request as ready for review June 3, 2021 11:58
@hvitved hvitved requested review from a team as code owners June 3, 2021 11:58
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Jun 3, 2021
@hvitved
Copy link
Contributor Author

hvitved commented Jun 4, 2021

The performance improvements are a result of sourceNode and sinkNode now being cached.

@hvitved hvitved merged commit 3c7c10a into github:main Jun 4, 2021
@hvitved hvitved deleted the java/shared-external-source-sink branch June 4, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschackmull aschackmull aschackmull approved these changes

Assignees

@aschackmull aschackmull

Labels
C# Java no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvitved @aschackmull