C++: Combine results for cpp/weak-cryptographic-algorithm #6007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think so. There may (hopefully!) at some point be a third PR increasing the |
Looks like I forgot to make a PR for the internal test as well. I'll do that later today. |
geoffw0
added
the
depends on internal PR
|
Internal changes made. This should be ready to merge (together with the other PR) when the tests pass on that one. |
MathiasVP
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue here is that
cpp/weak-cryptographic-algorithmoften reports many pieces of evidence of the same issue, that a particular cryptographic algorithm is in use (see https://lgtm.com/rules/2162200683/alerts/, though that is probably still showing an older version of the query). The noise of all these extra results is particularly unpleasant when viewing them alongside other query results.The solution in this PR is to combine all alerts in a file into a single alert at the first location, with
$@references to the other results. The results look much cleaner on LGTM.