Python: Add type-tracking test for attrs set in functions/methods #6046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tausbn
requested changes
Jun 9, 2021
There was a problem hiding this comment.
I have added a few suggestions where I believe the test annotations to be incomplete.
As for the tests themselves, I'm not sure how we would be extending type tracking to also handle instance variables (though admittedly I haven't thought about it much), but having the tests is always useful (if nothing else it demonstrates what the limits of the approach are).
python/ql/test/experimental/dataflow/typetracking/attribute_tests.py
Outdated
Show resolved
Hide resolved
python/ql/test/experimental/dataflow/typetracking/attribute_tests.py
Outdated
Show resolved
Hide resolved
python/ql/test/experimental/dataflow/typetracking/attribute_tests.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Taus <tausbn@github.com>
|
Sure, those annotations are more complete 👍 |
This one just works out of the box 💪
tausbn
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't quite sure how to attack solving this, but wanted to get the tests in