JS: Add support for knex #6086
Merged
JS: Add support for knex #6086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgerf
added
JS
JS:changes-sources-or-sinks
esbena
approved these changes
Jun 16, 2021
| ) | ||
| } | ||
|
|
||
| override DataFlow::Node getAQueryArgument() { none() } |
There was a problem hiding this comment.
Minor usability: I suppose it can be confusing for new users of the library to observe that SQL::SqlString exists and that DatabaseAccess::getAQueryArgument does not. But I can see how it is messy to tie the two together in this model.
There was a problem hiding this comment.
I guess we could say that the receiver of the then call is the query argument (i.e the Knex query object is the query). But we don't actually use the result for anything currently so it's hard to say what would be a useful implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for knex, a SQL query builder library.
Evaluations: (internal links)