Skip to content

C++: Adjust test expectations after frontend upgrade #6147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2021
Merged

C++: Adjust test expectations after frontend upgrade #6147

merged 1 commit into from
Jun 23, 2021

Conversation

AlexDenisov
Copy link
Contributor

No description provided.

@AlexDenisov AlexDenisov added C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR labels Jun 23, 2021
@AlexDenisov AlexDenisov requested a review from a team as a code owner June 23, 2021 12:40
MathiasVP
MathiasVP approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see, it looks like this change adds an lvalue-to-rvalue conversion to the conditional expression here:

template<typename T>
T min(T x, T y) {
  return (x < y) ? x : y;
}

AFAIK this looks like a sensible thing, indeed!

@igfoo igfoo merged commit 089e4e2 into github:main Jun 23, 2021
@AlexDenisov AlexDenisov deleted the adjust_test_expectation branch June 23, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathiasVP MathiasVP MathiasVP approved these changes

Assignees
No one assigned
Labels
C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexDenisov @MathiasVP @igfoo