-
Notifications
You must be signed in to change notification settings - Fork 1.8k
C#: Start using CSV based flow models #6148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C#: Start using CSV based flow models #6148
Conversation
71a4822
to
9bc856d
Compare
m = responseClass.getABinaryWriteMethod() | ||
| | ||
// Calls to these methods, or overrides of them | ||
this.getExpr() = m.getAnOverrider*().getParameter(0).getAnAssignedArgument() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't express getAnOverrider*
in CSV, but anyways, HttpResponse
is sealed
.
d7cc6e9
to
e05ef6c
Compare
e123bcc
to
521d018
Compare
a17f3fc
to
6fceb1b
Compare
csharp/ql/test/library-tests/dataflow/library/FlowSummaries.expected
Outdated
Show resolved
Hide resolved
… just remote ones
3ba39f1
to
23badc4
Compare
The PR was rebased to fix merge conflicts. |
javaGenerated file changes for java
- Framework / library,Package,Remote flow sources,Taint & value steps,Sinks (total),`CWE‑022` :sub:`Path injection`,`CWE‑036` :sub:`Path traversal`,`CWE‑079` :sub:`Cross-site scripting`,`CWE‑089` :sub:`SQL injection`,`CWE‑090` :sub:`LDAP injection`,`CWE‑094` :sub:`Code injection`,`CWE‑319` :sub:`Cleartext transmission`
+ Framework / library,Package,Flow sources,Taint & value steps,Sinks (total),`CWE‑022` :sub:`Path injection`,`CWE‑036` :sub:`Path traversal`,`CWE‑079` :sub:`Cross-site scripting`,`CWE‑089` :sub:`SQL injection`,`CWE‑090` :sub:`LDAP injection`,`CWE‑094` :sub:`Code injection`,`CWE‑319` :sub:`Cleartext transmission` |
8954c5d
to
3b58569
Compare
The comment #6148 (comment) is specific to this PR. The "remote vs all flows" change will generate some noise on other PRs too: PRs that were opened before this change will report different coverage files in the previous run of the job than in the current one, so a comment will be added to them. (Usually the comment that a recent change removed a previously reported coverage change will be added.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approach LGTM. Thanks for starting this work Tamas.
csharp/ql/src/semmle/code/csharp/dataflow/LibraryTypeDataFlow.qll
Outdated
Show resolved
Hide resolved
csharp/ql/src/semmle/code/csharp/dataflow/LibraryTypeDataFlow.qll
Outdated
Show resolved
Hide resolved
csharp/ql/src/semmle/code/csharp/dataflow/LibraryTypeDataFlow.qll
Outdated
Show resolved
Hide resolved
a469cf0
to
6754980
Compare
6754980
to
0946ae2
Compare
This PR
The workflows have been tested here:
runrun