Upgrade database in coverage report jobs

[tamasvajk]

The framework coverage jobs download the last released codeql CLI, create a DB, and then run some queries. If the database schema is updated since the release, then the query execution fails. Therefore, this PR adds a codeql database upgrade call to upgrade the created database.

Jobs on main:

• current coverage is failing
• timeseries coverage is producing empty report
• Failing PR check

Working jobs in dsp-testing based on this PR:

• current coverage
• timeseries coverage
• PR check

[adityasharad]

What is the exact error you're seeing from codeql query run? Can you get the stderr logs by running locally?

CodeQL performs "non-destructive" database upgrades automatically when you run a query, which most of the time should avoid the need for a separate upgrade step. Can you also try passing a --search-path to query run instead of adding a separate call to database upgrade?

[tamasvajk]

@adityasharad Here's the output:

❯ ./codeql query run /Users/tamasvajk/dev/semmle-code/ql/java/ql/src/meta/frameworks/Coverage.ql --database empty-java --output output-java.csv.bqrs
Compiling query plan for /Users/tamasvajk/dev/semmle-code/ql/java/ql/src/meta/frameworks/Coverage.ql.
Compiling upgrade for /Users/tamasvajk/dev/semmle-code/ql/java/ql/src/meta/frameworks/Coverage.ql
A fatal error occurred: The CodeQL database at empty-java
is not compatible with the QL library ../../../semmle-code/ql/java/ql/src/meta/frameworks/Coverage.ql uses.
The database may be too new for the QL libraries the query is using; try upgrading them.
Alternatively, running 'codeql database upgrade empty-java' with an appropriate --search-path option might help.

Adding --search-path to the query seems to be working too, however being explicit with the upgrade is probably better for future understanding of the code.

[adityasharad]

I would recommend adding --search-path to the query run and commenting that it's needed to find the upgrades.
(If your query were outside the query repo you would need --search-path anyway, it only works now because it happens to be inside the pack it depends on.)

[tamasvajk]

New workflow runs:

• timeseries coverage report
• current coverage report

[tamasvajk]

I've rebased this PR to fix merge conflicts. New runs after the rebase:

• https://github.com/dsp-testing/codeql-csv-coverage-pr-commenter/actions/runs/986152825
• https://github.com/dsp-testing/codeql-csv-coverage-pr-commenter/actions/runs/986152669