C#: Start using 'options' files in tests #6181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamasvajk
force-pushed
the
feature/test-options-files
branch
from
d1a3e2c to
ffbfef6
Compare
tamasvajk
commented
Jun 29, 2021
tamasvajk
force-pushed
the
feature/test-options-files
branch
from
040e88b to
9cba243
Compare
|
Tests are passing after the first 4 commits (moving extractor options to |
tamasvajk
force-pushed
the
feature/test-options-files
branch
from
d6d5afb to
5e27703
Compare
|
@hvitved Thanks for the review. I rebased this PR, and removed the two commits. |
hvitved
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves all
semmle-extractor-options:from.csfiles tooptionsfiles in the test folder. Except:optionsfiles, and we can't mix C# options with ASP options, sosemmle-extractor-optionsfrom.csfiles where the folder also contains.aspxfiles are not moved.--separate-compilationis still file based, so these extractor options are not moved from.csfiles.