-
Notifications
You must be signed in to change notification settings - Fork 1.8k
C#: Migrate SQL sinks to CSV format #6196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
csharpGenerated file changes for csharp
- System,"``System.*``, ``System``",3,13,5,5
+ System,"``System.*``, ``System``",3,13,28,5
+ Others,"``Dapper``, ``Microsoft.ApplicationBlocks.Data``, ``MySql.Data.MySqlClient``",,,130,
- Totals,,3,13,5,5
+ Totals,,3,13,158,5
- package,sink,source,summary,sink:html,sink:xss,source:local,summary:taint
+ package,sink,source,summary,sink:html,sink:sql,sink:xss,source:local,summary:taint
+ Dapper,54,,,,54,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,28,,,
+ MySql.Data.MySqlClient,48,,,,48,,,
- System,5,3,13,4,1,3,13
+ System,28,3,13,4,23,1,3,13 |
3203e42
to
fdf3cf4
Compare
csharpGenerated file changes for csharp
- System,"``System.*``, ``System``",3,13,5,5
+ System,"``System.*``, ``System``",3,13,28,5
+ Others,"``Dapper``, ``Microsoft.ApplicationBlocks.Data``, ``MySql.Data.MySqlClient``",,,119,
- Totals,,3,13,5,5
+ Totals,,3,13,147,5
- package,sink,source,summary,sink:html,sink:xss,source:local,summary:taint
+ package,sink,source,summary,sink:html,sink:sql,sink:xss,source:local,summary:taint
+ Dapper,43,,,,43,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,28,,,
+ MySql.Data.MySqlClient,48,,,,48,,,
- System,5,3,13,4,1,3,13
+ System,28,3,13,4,23,1,3,13 |
9cffcef
to
0d73168
Compare
0d73168
to
f66d7c9
Compare
csharpGenerated file changes for csharp
- System,"``System.*``, ``System``",3,13,5,5
+ System,"``System.*``, ``System``",3,13,28,5
+ Others,"``Dapper``, ``Microsoft.ApplicationBlocks.Data``, ``MySql.Data.MySqlClient``",,,131,
- Totals,,3,13,5,5
+ Totals,,3,13,159,5
- package,sink,source,summary,sink:html,sink:xss,source:local,summary:taint
+ package,sink,source,summary,sink:html,sink:sql,sink:xss,source:local,summary:taint
+ Dapper,55,,,,55,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,28,,,
+ MySql.Data.MySqlClient,48,,,,48,,,
- System,5,3,13,4,1,3,13
+ System,28,3,13,4,23,1,3,13 |
f66d7c9
to
518cad4
Compare
518cad4
to
aba8a27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
aba8a27
to
72bb4f0
Compare
72bb4f0
to
8232698
Compare
@hvitved Thanks for the approval. I've rebased this PR to fix merge conflicts after the ServiceStack PR got merged. |
This PR migrates some SQL sinks (known
IDbCommand
implementors, EntityFramework, Dapper) to CSV format.Diff job
Some required fixes are added here:
NullableType
to include qualified name of type arguments #6259