Skip to content

JavaScript: Add query help for two externally contributed queries. #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 6, 2018
Merged

JavaScript: Add query help for two externally contributed queries. #620

merged 3 commits into from
Dec 6, 2018

Conversation

xiemaisi
Copy link

@xiemaisi xiemaisi commented Dec 5, 2018

Queries were added in #132.

I've also added another CWE tag that seemed relevant to HttpToFileAccess and added the qhelp examples to the tests for both queries.

@xiemaisi xiemaisi added the JS label Dec 5, 2018
@xiemaisi xiemaisi added this to the 1.19 milestone Dec 5, 2018
@xiemaisi xiemaisi requested review from a user and mchammer01 December 5, 2018 13:15
@xiemaisi xiemaisi requested a review from a team as a code owner December 5, 2018 13:15
@ghost ghost self-assigned this Dec 5, 2018
ghost
ghost previously approved these changes Dec 5, 2018
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Perhaps two extra references could be added.

@xiemaisi
Copy link
Author

xiemaisi commented Dec 5, 2018

Good idea; added to both of them.

felicitymay
felicitymay approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the extra qhelp topics. All LGTM.

@xiemaisi xiemaisi merged commit 305b8a6 into github:rc/1.19 Dec 6, 2018
@felicitymay felicitymay removed the request for review from mchammer01 December 6, 2018 08:19
@xiemaisi xiemaisi deleted the js/qhelp-for-ms-queries branch January 10, 2019 16:26
@kamarcum kamarcum unassigned ghost Apr 28, 2020
cklin pushed a commit that referenced this pull request May 23, 2022
Merge pull request #620 from github/aeisenberg/version-policies
b57d329 
Add version policies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felicitymay felicitymay felicitymay approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
JS
Projects
None yet
Milestone
1.19
Development

Successfully merging this pull request may close these issues.
2 participants
@xiemaisi @felicitymay