Skip to content

Python: port redos .qhelp from js #6209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2021
Merged

Python: port redos .qhelp from js #6209

merged 1 commit into from
Jul 2, 2021

Conversation

yoff
Copy link
Contributor

@yoff yoff commented Jul 2, 2021

During the recent redos port, the .qhelp-files were somehow missed. These are adapted and added in this PR.

@yoff yoff requested a review from a team as a code owner July 2, 2021 09:38
@yoff yoff added the no-change-note-required This PR does not need a change note label Jul 2, 2021
RasmusWL
RasmusWL approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@RasmusWL RasmusWL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Too bad we couldn't share these directly through identical-files 😞 but I see that almost all of these files have some language specific part to them 😞

@RasmusWL RasmusWL merged commit 3c8c2d1 into github:main Jul 2, 2021
@yoff
Copy link
Contributor Author

yoff commented Jul 2, 2021

Indeed, perhaps we can work them into a more generic form later..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RasmusWL RasmusWL RasmusWL approved these changes

Assignees
No one assigned
Labels
documentation no-change-note-required This PR does not need a change note Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoff @RasmusWL