Skip to content

Dataflow: Refactor call context check #6211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aschackmull
Copy link
Contributor

The first commit just moves some code around. The second commit contains the actual change.

@aschackmull aschackmull added the no-change-note-required This PR does not need a change note label Jul 2, 2021
@aschackmull aschackmull requested review from a team as code owners July 2, 2021 10:02
@smowton
Copy link
Contributor

smowton commented Jul 2, 2021

Go is somewhat behind the dataflow lib right now, so go ahead and we'll deal with any problems async

@aschackmull aschackmull force-pushed the dataflow/refactor-call-context-check branch from 455518e to 20a2f8f Compare July 13, 2021 12:14
hvitved
hvitved previously approved these changes Jul 14, 2021
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's see if the differences jobs are good.

@aschackmull aschackmull force-pushed the dataflow/refactor-call-context-check branch from 20a2f8f to 0ccb213 Compare July 14, 2021 08:36
@aschackmull
Copy link
Contributor Author

All diff jobs are looking good!

@aschackmull aschackmull merged commit 8ccdd4f into github:main Jul 15, 2021
@aschackmull aschackmull deleted the dataflow/refactor-call-context-check branch July 15, 2021 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# C++ Java no-change-note-required This PR does not need a change note Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants