-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add docs for summary type queries #6257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/query-metadata-style-guide.md
Outdated
|
||
Metrics and other pieces of summary information will be output in the SARIF format according to the [specification](https://docs.google.com/document/d/1V3zpkj0OGh8GEUVwACRx7fiafE5zklujAftZaYUyf9s/edit#heading=h.d6vfrrmrajbb) agreed with the Code Scanning team. | ||
|
||
Such queries should have the [`summary`](https://github.com/github/semmle-code/blob/4203403960b78c77c0a9563cce1bd85891cb4459/queryserver-client/src/com/semmle/api/QueryMetadata.java#L28-L32) tag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This refers to a private repository.
docs/query-metadata-style-guide.md
Outdated
@@ -157,6 +157,15 @@ If your query is a security query, use one or more `@tags` to associate it with | |||
|
|||
When you tag a query like this, the associated CWE pages from [MITRE.org](http://cwe.mitre.org/index.html) will automatically appear in the reference section of its associated qhelp file. | |||
|
|||
#### Metric/summary `@tags` | |||
|
|||
Metrics and other pieces of summary information will be output in the SARIF format according to the [specification](https://docs.google.com/document/d/1V3zpkj0OGh8GEUVwACRx7fiafE5zklujAftZaYUyf9s/edit#heading=h.d6vfrrmrajbb) agreed with the Code Scanning team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This prompts me to login, so I guess you should probably replace this link with something that is "more" public.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pointers. The internal links aren't suitable for inclusion here. Once summary
queries are more widespread I hope we will provide external documentation for integration and then we could link to that here.
c9ace9b
to
5d849a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few suggestions taken from the docs you originally linked.
Co-authored-by: Aditya Sharad <6874315+adityasharad@users.noreply.github.com>
Oh wait! Please retarget against |
Done, thanks! Not sure how that happened. |
No description provided.