Skip to content

Add docs for summary type queries #6257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 14, 2021
Merged

Conversation

rneatherway
Copy link
Contributor

No description provided.


Metrics and other pieces of summary information will be output in the SARIF format according to the [specification](https://docs.google.com/document/d/1V3zpkj0OGh8GEUVwACRx7fiafE5zklujAftZaYUyf9s/edit#heading=h.d6vfrrmrajbb) agreed with the Code Scanning team.

Such queries should have the [`summary`](https://github.com/github/semmle-code/blob/4203403960b78c77c0a9563cce1bd85891cb4459/queryserver-client/src/com/semmle/api/QueryMetadata.java#L28-L32) tag.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refers to a private repository.

@@ -157,6 +157,15 @@ If your query is a security query, use one or more `@tags` to associate it with

When you tag a query like this, the associated CWE pages from [MITRE.org](http://cwe.mitre.org/index.html) will automatically appear in the reference section of its associated qhelp file.

#### Metric/summary `@tags`

Metrics and other pieces of summary information will be output in the SARIF format according to the [specification](https://docs.google.com/document/d/1V3zpkj0OGh8GEUVwACRx7fiafE5zklujAftZaYUyf9s/edit#heading=h.d6vfrrmrajbb) agreed with the Code Scanning team.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prompts me to login, so I guess you should probably replace this link with something that is "more" public.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pointers. The internal links aren't suitable for inclusion here. Once summary queries are more widespread I hope we will provide external documentation for integration and then we could link to that here.

@rneatherway rneatherway force-pushed the rneatherway/summary-docs branch from c9ace9b to 5d849a9 Compare July 12, 2021 15:26
Copy link
Collaborator

@adityasharad adityasharad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few suggestions taken from the docs you originally linked.

rneatherway and others added 2 commits July 12, 2021 17:34
Co-authored-by: Aditya Sharad <6874315+adityasharad@users.noreply.github.com>
adityasharad
adityasharad previously approved these changes Jul 13, 2021
@adityasharad
Copy link
Collaborator

Oh wait! Please retarget against main.

@rneatherway rneatherway changed the base branch from master to main July 14, 2021 09:12
@rneatherway rneatherway dismissed adityasharad’s stale review July 14, 2021 09:12

The base branch was changed.

@rneatherway
Copy link
Contributor Author

Oh wait! Please retarget against main.

Done, thanks! Not sure how that happened.

@adityasharad adityasharad merged commit e0a123c into main Jul 14, 2021
@adityasharad adityasharad deleted the rneatherway/summary-docs branch July 14, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants