Python: Support import * in API graphs
#6274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the current test out of `test.py`, as otherwise any unknown global (like, say, `sink`) would _also_ be considered to be something potentially defined in `unknown`.
This will make it possible to reuse for names defined in `import *`.
RasmusWL
requested changes
Jul 19, 2021
Co-authored-by: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com>
I debated whether to add a
`MISSING: use=moduleImport("builtins").getMember("print").getReturn()`
annotation to the last line.
Ultimately, I decided to add it, as we likely _do_ want this information
to propagate into inner functions (even if the value of `var2` may
change before `func4` is called).
RasmusWL
reviewed
Jul 21, 2021
Co-authored-by: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com>
RasmusWL
approved these changes
Sep 10, 2021
There was a problem hiding this comment.
LGTM 👍
Internal performance test looks fine, so no cause for concerns there ✔️
There was a brief moment when I thought that the following annotation meant that we think that bar is print 😆 (and I was super confused)
print(bar2) #$ use=moduleImport("builtins").getMember("print").getReturn()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A slightly awkward implementation, mostly due to the fact that
import *may appear in a local scope, and we don't want this to pollute unrelated scopes.Also, our use of
GlobalSsaVariables means we don't consider the first reference to a global (which may come from animport *in the global scope) to be aLocalSourceNode. This should go away once we have fixed the remaining issues surroundingEssaNodes.Needs a performance test (as we're growing the API graph yet again), and possibly also a change note.