Skip to content

CodeQL: Display CWE coverage information by language #6327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 2, 2021

Conversation

ethanpalm
Copy link
Contributor

@ethanpalm ethanpalm commented Jul 19, 2021

This PR updates the CodeQL docs to have pages that display CWE coverage per language as well as a page that has the full CWE coverage. The internally mentioned companion PR will update the workflow for generating the per-language Markdown tables.

Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! Once we've tweaked the automation, we can test that it all looks good 🎉

@ethanpalm ethanpalm self-assigned this Jul 19, 2021
@ethanpalm ethanpalm marked this pull request as ready for review July 20, 2021 17:14
@ethanpalm ethanpalm changed the title [WIP] CWE coverage tables Display CWE coverage information by language Jul 20, 2021
@ethanpalm ethanpalm changed the title Display CWE coverage information by language CodeQL: Display CWE coverage information by language Jul 20, 2021
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spotted some formatting bugs that I'd missed previously! 🙃 Otherwise, LGTM from the CodeQL/workflow side ⚡

felicitymay
felicitymay previously approved these changes Jul 28, 2021
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible and I can't see anything that Shati's overlooked. I'll be interested to see the results 🚀

It's probably worth dropping a note in the README file or in the general notes about the CodeQL docs processes for this process. I don't think that it's currently covered and we will need to add Ruby at some point.

Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the readme file.

@ethanpalm ethanpalm merged commit 2c6977e into github:main Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants