Python: Hotfix LocalSourceNode
#6351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporarily instates `TypeTrackingNode` as an alias of `LocalSourceNode` as having it as a separate class lead to performance regressions. In the hopes that this will be resolved in the near future, I have left the current `TypeTrackingNode` implementation in situ, but hidden inside a `FutureWork` private module.
... in a local scope. Or rather, remove these from the `hasLocalSource` relation. This prevents a quadratic blowup when the same global is mentioned _a lot_ of times within a single function scope.
RasmusWL
approved these changes
Jul 22, 2021
This was referenced Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates the changes from #6344 and #6345 and updates the change note to say that the use of
LocalSourceNodein type tracking is being deprecated.