Java: Model guava cache package #6387

joefarebrother · 2021-07-29T15:43:33Z

No description provided.

github-actions · 2021-07-29T15:45:54Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged. The following differences were found:

java

Generated file changes for java

Changes to framework-coverage-java.rst:

-    `Google Guava <https://guava.dev/>`_,``com.google.common.*``,,158,6,,6,,,,,
+    `Google Guava <https://guava.dev/>`_,``com.google.common.*``,,172,6,,6,,,,,
-    Totals,,84,2465,296,13,6,6,107,33,1,66
+    Totals,,84,2479,296,13,6,6,107,33,1,66

Changes to framework-coverage-java.csv:

+ com.google.common.cache,,,14,,,,,,,,,,,,,,,,14

smowton · 2021-08-09T09:54:01Z

java/ql/src/semmle/code/java/frameworks/guava/Cache.qll

+        "com.google.common.cache;LoadingCache;true;get;(Object);;MapValue of Argument[-1];ReturnValue;value",
+        "com.google.common.cache;LoadingCache;true;getUnchecked;(Object);;MapValue of Argument[-1];ReturnValue;value",
+        "com.google.common.cache;LoadingCache;true;apply;(Object);;MapValue of Argument[-1];ReturnValue;value",
+        "com.google.common.cache;LoadingCache;true;getAll;(Iterable);;Element of Argument[0];MapKey of ReturnValue;value",


Suggest MapKey of Argument[-1] instead of Element of Argument[0], since elements that only occur in the requested keys won't actually be present in the result

Hmm; stritly apeaking its the intersection of these, which we don't have a good way to model.

Indeed, coming from the MapKey of the qualifier would at least be consistent with entrySet and similar though

github-actions · 2021-08-10T14:07:39Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged. The following differences were found:

java

Generated file changes for java

Changes to framework-coverage-java.rst:

-    `Google Guava <https://guava.dev/>`_,``com.google.common.*``,,158,6,,6,,,,,
+    `Google Guava <https://guava.dev/>`_,``com.google.common.*``,,172,6,,6,,,,,
-    Totals,,84,2711,398,13,6,6,107,33,1,66
+    Totals,,84,2725,398,13,6,6,107,33,1,66

Changes to framework-coverage-java.csv:

+ com.google.common.cache,,,14,,,,,,,,,,,,,,,,,,,,14

java/ql/src/semmle/code/java/frameworks/guava/Cache.qll

intrigus-lgtm · 2021-08-12T14:30:51Z

java/ql/src/semmle/code/java/frameworks/guava/Cache.qll

+        "com.google.common.cache;LoadingCache;true;get;(Object);;MapValue of Argument[-1];ReturnValue;value",
+        "com.google.common.cache;LoadingCache;true;getUnchecked;(Object);;MapValue of Argument[-1];ReturnValue;value",
+        "com.google.common.cache;LoadingCache;true;apply;(Object);;MapValue of Argument[-1];ReturnValue;value",
+        "com.google.common.cache;LoadingCache;true;getAll;(Iterable);;MapKey of Argument[-1];MapKey of ReturnValue;value", // technically, an interection between MapKey of Argument[-1] and Element of Argument[0]; but we don't model intersections.


Suggested change

"com.google.common.cache;LoadingCache;true;getAll;(Iterable);;MapKey of Argument[-1];MapKey of ReturnValue;value", // technically, an interection between MapKey of Argument[-1] and Element of Argument[0]; but we don't model intersections.

"com.google.common.cache;LoadingCache;true;getAll;(Iterable);;MapKey of Argument[-1];MapKey of ReturnValue;value", // technically, an intersection between MapKey of Argument[-1] and Element of Argument[0]; but we don't model intersections.

It seems like getAll creates elements that are missing, so this source should be Element of Argument[0], right? Also, if you wanted to model the intersections Cache.getAll above should probably also have a MapKey model.

Good point; the fact that it creates missing elements means it's not actually an intersection; rather it has flow from Element of Argument[0] to MapKey of Argument[-1] and Element of Argument[0] to MapKey of ReturnValue.

github-actions · 2021-08-17T15:49:39Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged. The following differences were found:

java

Generated file changes for java

Changes to framework-coverage-java.rst:

-    `Google Guava <https://guava.dev/>`_,``com.google.common.*``,,158,6,,6,,,,,
+    `Google Guava <https://guava.dev/>`_,``com.google.common.*``,,175,6,,6,,,,,
-    Totals,,84,2711,398,13,6,6,107,33,1,66
+    Totals,,84,2728,398,13,6,6,107,33,1,66

Changes to framework-coverage-java.csv:

+ com.google.common.cache,,,17,,,,,,,,,,,,,,,,,,,,17

joefarebrother added 5 commits July 29, 2021 14:52

Model guava cache package

3bcb46f

Generate tests and stubs

096509b

Add more stubs

f1ca29a

Replace get and newWith methods with real implementations

e23f666

Add change note

227818a

joefarebrother requested a review from a team as a code owner July 29, 2021 15:43

github-actions bot added documentation Java labels Jul 29, 2021

smowton reviewed Aug 9, 2021

View reviewed changes

Update model for getAll

207c753

smowton previously approved these changes Aug 12, 2021

View reviewed changes

java/ql/src/semmle/code/java/frameworks/guava/Cache.qll Outdated Show resolved Hide resolved

joefarebrother dismissed smowton’s stale review via 84ccb61 August 12, 2021 13:04

smowton previously approved these changes Aug 12, 2021

View reviewed changes

intrigus-lgtm reviewed Aug 12, 2021

View reviewed changes

joefarebrother added 2 commits August 16, 2021 13:50

Update models for Cache.getAllPresent and LoadingCache.getAll

48c61fc

Update tests

076aeb5

joefarebrother dismissed smowton’s stale review via 076aeb5 August 17, 2021 15:46

joefarebrother force-pushed the guava-cache branch from 84ccb61 to 076aeb5 Compare August 17, 2021 15:46

smowton approved these changes Aug 19, 2021

View reviewed changes

joefarebrother merged commit 9dc28eb into github:main Aug 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Java: Model guava cache package #6387

Java: Model guava cache package #6387

Uh oh!

joefarebrother commented Jul 29, 2021

Uh oh!

github-actions bot commented Jul 29, 2021

Uh oh!

smowton Aug 9, 2021

Uh oh!

joefarebrother Aug 9, 2021

Uh oh!

smowton Aug 9, 2021

Uh oh!

github-actions bot commented Aug 10, 2021

Uh oh!

Uh oh!

intrigus-lgtm Aug 12, 2021

Uh oh!

sauyon Aug 12, 2021

Uh oh!

joefarebrother Aug 16, 2021 •

edited

Loading

Uh oh!

github-actions bot commented Aug 17, 2021

Uh oh!

Uh oh!

	"com.google.common.cache;LoadingCache;true;getAll;(Iterable);;MapKey of Argument[-1];MapKey of ReturnValue;value", // technically, an interection between MapKey of Argument[-1] and Element of Argument[0]; but we don't model intersections.
	"com.google.common.cache;LoadingCache;true;getAll;(Iterable);;MapKey of Argument[-1];MapKey of ReturnValue;value", // technically, an intersection between MapKey of Argument[-1] and Element of Argument[0]; but we don't model intersections.

Java: Model guava cache package #6387

Java: Model guava cache package #6387

Uh oh!

Conversation

joefarebrother commented Jul 29, 2021

Uh oh!

github-actions bot commented Jul 29, 2021

java

Generated file changes for java

Uh oh!

smowton Aug 9, 2021

Choose a reason for hiding this comment

Uh oh!

joefarebrother Aug 9, 2021

Choose a reason for hiding this comment

Uh oh!

smowton Aug 9, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 10, 2021

java

Generated file changes for java

Uh oh!

Uh oh!

intrigus-lgtm Aug 12, 2021

Choose a reason for hiding this comment

Uh oh!

sauyon Aug 12, 2021

Choose a reason for hiding this comment

Uh oh!

joefarebrother Aug 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 17, 2021

java

Generated file changes for java

Uh oh!

Uh oh!

joefarebrother Aug 16, 2021 •

edited

Loading