Java: Fix Field.getInitializer() matching non-initializer assignments

[Marcono1234]

Previously Field.getInitializer() would erroneously match assignments which occurred in the intializer of a different field. For example:

class FieldInitializer {
    String f = "a";
    // Erroneously considered `f = "b"` to be initializing `f`
    String otherF = f = "b";
}

Query:

import java

from Field f
where f.getCompilationUnit().hasName("FieldInitializer")
select f, f.getInitializer()

[Marcono1234]

Should I add pragma[only_bind_out] here again? If so to which of these predicate usages?

[smowton]

I tried reproducing the bad join order observed in #6187, but the latest codeql doesn't produce that order any longer. We should just run a performance evaluation on this to see if it behaves badly.

[Marcono1234]

Thanks for adding the test!