Packaging: Refactor cpp libraries #6488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses new style naming scheme.
aeisenberg
force-pushed
the
aeisenberg/pack/cpp
branch
from
5e2e014 to
9779426
Compare
|
It looks like a handful of files under csharp/ql/lib/semmle/code/csharp/frameworks/system/data/ were accidentally committed |
|
Thanks. You're right. Let me remove them. |
This PR separates the core cpp packs into `codeql/cpp-queries` and `codeql/cpp-all`. There are very few lines of code changed. Almost all changes are moving files around.
aeisenberg
force-pushed
the
aeisenberg/pack/cpp
branch
from
520af02 to
3b05a60
Compare
We can't have recursive references to query packs.
aeisenberg
force-pushed
the
aeisenberg/pack/cpp
branch
from
3b05a60 to
d13ce88
Compare
Also, fix up some library path dependencies.
dbartol
previously approved these changes
Aug 17, 2021
dbartol
added
the
depends on internal PR
|
Yes, I was trying to make the smallest change possible at first. And we can complete the changes later. |
aeisenberg
force-pushed
the
aeisenberg/pack/cpp
branch
from
6982ff8 to
03d6b15
Compare
|
All checks have passed on this PR except |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the core cpp packs into
codeql/cpp-queriesandcodeql/cpp-all.There are very few lines of code changed. Almost all changes are moving
files around.