Skip to content

All languages: Add getPrimaryQlClasses() #6536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2021
Merged

Conversation

igfoo
Copy link
Contributor

@igfoo igfoo commented Aug 23, 2021

This is a non-overridable predicate that concatenates all the getAPrimaryQlClass() results into a comma-separated string.

@igfoo igfoo requested review from a team as code owners August 23, 2021 12:14
@igfoo igfoo marked this pull request as draft August 23, 2021 12:18
@igfoo igfoo force-pushed the igfoo/getPrimaryQlClasses branch from 36a82aa to 0f16f7d Compare August 23, 2021 13:16
This is a non-overridable predicate that concatenates all the
getAPrimaryQlClass() results into a comma-separated string.
@igfoo igfoo force-pushed the igfoo/getPrimaryQlClasses branch from 0f16f7d to a9db1c5 Compare August 23, 2021 14:50
Copy link
Contributor

@jbj jbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

Co-authored-by: Jonas Jensen <jbj@github.com>
@igfoo igfoo marked this pull request as ready for review August 23, 2021 15:52
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C# 👍

@igfoo igfoo merged commit 43355fe into main Aug 23, 2021
@igfoo igfoo deleted the igfoo/getPrimaryQlClasses branch August 23, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants