Java: Migrate Objects flow to CSV model
#6555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 26, 2021 12:06
smowton
reviewed
Aug 26, 2021
| this.hasName("toString") and returnsArgNo = 1 | ||
| ) | ||
| or | ||
| this.getDeclaringType().getASourceSupertype*().hasQualifiedName("java.util", "Stack") and |
There was a problem hiding this comment.
Removed but not re-added -- if the tests don't notice that, we're missing a test. Please add a basic test for these methods.
There was a problem hiding this comment.
As mentioned in the PR comment, I believe this is covered by Collections.qll
Co-authored-by: Chris Smowton <smowton@github.com>
smowton
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out of 6407
Removed the Stack#push part as this is already modelled in
Collections.qll