C#: Handle non-critical exception in CIL local variable extraction #6578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
approved these changes
Sep 1, 2021
|
|
||
| for (var l = 0; l < this.locals.Length; ++l) | ||
| if (!hasError) |
There was a problem hiding this comment.
I have a slight preference for if (hasError) return, as it reduces indentation.
There was a problem hiding this comment.
We're still able to CIL extract the body even through we had trouble with the local variables, so we can't return early. Also, this method has yield returns , which can't be inside try-catch blocks. That's why this hasError was introduced. It's ugly, but I didn't have any better idea.
There was a problem hiding this comment.
Ah, I mistakenly read the } on line 152 as the end of the method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6439.
I couldn't find a better way of handling this than catching the exception, logging it, and proceed with extraction. The assembly causing the issues was
Microsoft.mshtml. ILSpy has similar issue when displaying the IL from this assembly. ildasm has no such issue.