JS: Add support for TypeScript 4.4

[erik-krogh]

Adds support for TypeScript 4.4.
Adding support for TypeScript 4.4 was completely straight-forward, except for static initializer blocks.

It looks like static initializer blocks is making it's way into ECMAScript. So we should look into that later.
(I'll check it out after this PR is merged).

The List<Node> body; type in ClassBody is not the prettiest type.
But we need an ordered list that contains a mix of member-declarations and block-statements, so I think the only way to do better is to create an entirely new interface.

I haven't added getters for the new index signatures, because the available API still only exposes string/number index signatures.

No evaluation planned.

[asgerf]

Excellent work! Although as you say the representation of static initializers is indeed not very nice.

Couldn't we represent the static initializers using MemberDefinition? I mean that's literally defined as "a member definition in a class body". How about we add a new subclass of MemberDefinition, set the name to null and the value to the BlockStatement (and relaxing the bound on T).

[erik-krogh]

Couldn't we represent the static initializers using MemberDefinition? I mean that's literally defined as "a member definition in a class body". How about we add a new subclass of MemberDefinition, set the name to null and the value to the BlockStatement (and relaxing the bound on T).

I've done that.
But I've set the value to null instead of relaxing the bound on T for now.

I also need to do an update script, I'll do that later today.

[asgerf]

Thanks! Looks much better now 👍

[asgerf]

Stray import

[erik-krogh]

I added an upgrade script.

I've rebased on main, but other than that I didn't change the commit history.

[erik-krogh]

These are the failures from the CI:

    ql/javascript/ql/test/library-tests/CFG/CFG.ql: Extractor error (Extraction failed)
    ql/javascript/ql/test/library-tests/CFG/StaticInit.ql: Extractor error (Extraction failed)
    ql/javascript/ql/test/library-tests/TypeScript/Types/printAst.ql: Extractor error (Extraction failed)
    ql/javascript/ql/test/library-tests/TypeScript/Types/tests.ql: Extractor error (Extraction failed)

I'm not sure why, because it works just fine on my machine.

Edit: I'm even more confused.
It works just fine when I throw dca at it (report).

[asgerf]

Hm, it also works on my machine. 😕

[erik-krogh]

I've pulled the JS changes into this PR. Might make it easier to debug.
I'll ping when the tests start working.

[erik-krogh]

ping @asgerf

The tests are working.
The StaticInitializer was a parent of a Statement, but @static_initializer wasn't in the @stmt_parent type.
So some of the parent values in the stmts relation didn't match the annotated type.

I still have no idea why that only failed in the CI.

[asgerf]

Glad we got that sorted! 👍