Java: Simplify setup for flow tests using InlineExpectationsTest
#6591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atorralba
reviewed
Sep 3, 2021
atorralba
reviewed
Sep 3, 2021
atorralba
reviewed
Sep 3, 2021
|
A few inline comments. Otherwise it looks good to me, and it seems it can be a good quality-of-life change for new tests. |
added 17 commits
September 7, 2021 16:46
bmuskalla
force-pushed
the
inlineFlowTest
branch
from
6a7117b to
9e66ee1
Compare
|
Mostly LGTM, but maybe it needs an extra 👀 from someone else before merging. Also, note that there are some conflicts. |
owen-mc
previously approved these changes
Sep 13, 2021
aschackmull
reviewed
Sep 13, 2021
aschackmull
reviewed
Sep 13, 2021
aschackmull
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull out some common logic but allow overriding the the configurations. Try to provide sane default configurations that can be used across most tests.