Skip to content

C# Extend runtime callables to cover interface members with default implementation #6630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2021
Merged

C# Extend runtime callables to cover interface members with default implementation #6630

merged 1 commit into from
Sep 9, 2021

Conversation

tamasvajk
Copy link
Contributor

@tamasvajk tamasvajk commented Sep 6, 2021 •
edited
Loading

This PR makes an interface member with default implementation a RuntimeCallable.

Diff job Diff job

@github-actions github-actions bot added the C# label Sep 6, 2021
@tamasvajk tamasvajk mentioned this pull request Sep 6, 2021
Merged
9 tasks
@tamasvajk tamasvajk changed the title Extend runtime callables to interface members with default implementation C# Extend runtime callables to interface members with default implementation Sep 6, 2021
@tamasvajk tamasvajk marked this pull request as ready for review September 7, 2021 21:12
@tamasvajk tamasvajk requested a review from a team as a code owner September 7, 2021 21:12
@tamasvajk tamasvajk added the no-change-note-required This PR does not need a change note label Sep 7, 2021
@tamasvajk tamasvajk changed the title C# Extend runtime callables to interface members with default implementation C# Extend runtime callables to cover interface members with default implementation Sep 7, 2021
hvitved
hvitved requested changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test for this to ViableCallable.cs?

@tamasvajk tamasvajk force-pushed the feature/interface-runtimecallable branch from 4b539a3 to 3537861 Compare September 8, 2021 12:00
@tamasvajk tamasvajk force-pushed the feature/interface-runtimecallable branch from 3537861 to 9ab6c29 Compare September 8, 2021 13:07
@tamasvajk tamasvajk merged commit ad04099 into github:main Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvitved hvitved hvitved approved these changes

Assignees

@hvitved hvitved

Labels
C# no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamasvajk @hvitved