Update one more link in the QL training content #6754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to update a few more absolute links before we merge this. |
|
Thank you so much for fixing this. Let me know when you're ready for a review. 💖 |
jf205
commented
Sep 24, 2021
docs/codeql/support/ql-training.rst
Outdated
Comment on lines
42
to
48
| - `Introduction to variant analysis: CodeQL for C/C++ <cpp/intro-ql-cpp.html>`__–an introduction to variant analysis and CodeQL for C/C++ programmers. | ||
| - `Example: Bad overflow guard <cpp/bad-overflow-guard.html>`__–an example of iterative query development to find bad overflow guards in a C++ project. | ||
| - `Program representation: CodeQL for C/C++ <cpp/program-representation-cpp.html>`__–information on how CodeQL analysis represents C/C++ programs. | ||
| - `Introduction to local data flow <cpp/data-flow-cpp.html>`__–an introduction to analyzing local data flow in C/C++ using CodeQL, including an example demonstrating how to develop a query to find a real CVE. | ||
| - `Exercise: snprintf overflow <cpp/snprintf.html>`__–an example demonstrating how to develop a data flow query. | ||
| - `Introduction to global data flow <cpp/global-data-flow-cpp.html>`__–an introduction to analyzing global data flow in C/C++ using CodeQL. | ||
| - `Analyzing control flow: CodeQL for C/C++ <cpp/control-flow-cpp.html>`__–an introduction to analyzing control flow in C/C++ using CodeQL. |
There was a problem hiding this comment.
e664711 has updated the absolute links here to be relative so that we can more easily test them in the staging environment. I'm not sure how easy it'll be to test them now though 🤔
That was wrong. Another commit required.
jf205
commented
Sep 24, 2021
docs/codeql/support/ql-training.rst
Outdated
Comment on lines
53
to
58
| - `Introduction to variant analysis: CodeQL for Java <java/intro-ql-java.html>`__–an introduction to variant analysis and CodeQL for Java programmers. | ||
| - `Example: Query injection <java/query-injection-java.html>`__–an example of iterative query development to find unsanitized SPARQL injections in a Java project. | ||
| - `Program representation: CodeQL for Java <java/program-representation-java.html>`__–information on how CodeQL analysis represents Java programs. | ||
| - `Introduction to local data flow <java/data-flow-java.html>`__–an introduction to analyzing local data flow in Java using CodeQL, including an example demonstrating how to develop a query to find a real CVE. | ||
| - `Exercise: Apache Struts <java/apache-struts-java.html>`__–an example demonstrating how to develop a data flow query. | ||
| - `Introduction to global data flow <java/global-data-flow-java.html>`__–an introduction to analyzing global data flow in Java using CodeQL. |
There was a problem hiding this comment.
See also https://github.com/github/codeql/pull/6754/files#r715727011.
As above.
felicitymay
approved these changes
Sep 27, 2021
|
@jf205 - are you able to update the staging site with these changes? |
I'd prefer to pass this over to the docs team. I'm out of the loop when it comes to the update process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@felicitymay we missed one outdated link in the QL training content. @henti spotted it for us! ✨