Skip to content

C++: Small improvement to cpp/improper-null-termination #6757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 27, 2021
Merged

C++: Small improvement to cpp/improper-null-termination #6757

merged 2 commits into from
Sep 27, 2021

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Sep 24, 2021

Add a test case that had been discussed, and add understand that printf %s format arguments should be null terminated.

@geoffw0 geoffw0 added the C++ label Sep 24, 2021
@geoffw0 geoffw0 requested a review from a team as a code owner September 24, 2021 18:33
jbj
jbj approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@jbj jbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbj jbj merged commit b0836a6 into github:main Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbj jbj jbj approved these changes

Assignees
No one assigned
Labels
C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geoffw0 @jbj