JS: Move LDAP injection out of experimental #6781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Special Elements in Data Query Logic) to SqlInjection.ql
esbena
reviewed
Oct 27, 2021
| SearchOptions() { call.getMethodName() = "search" and this = call.getParameter(1) } | ||
| } | ||
|
|
||
| /** A creation of an LDAPjs filter, or object containing a filter, that doesn't sanitizes the input. */ |
There was a problem hiding this comment.
The "that doesn't sanitizes the input" bit is hard to derive from the LDAPFilterStep name. Cold the name include taint, somehow? TaintPreservingLDapFilterStep, NonSanitizingLDAPFilterStep...
Alternatively, we could keep the name, but add a default predicate:
predicate sanitizing() { none() }
| } | ||
| } | ||
|
|
||
| import semmle.javascript.security.IncompleteBlacklistSanitizer as IncompleteBlacklistSanitizer |
There was a problem hiding this comment.
Shouldn't the autoformatter have moved this up?
There was a problem hiding this comment.
No, it doesn't do that.
I got the import there because it's close to where the import is used.
I'm still mentioning the name of the library as |
esbena
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added LDAP as a sink for
js/sql-injection(it already has no-sql / graphql injection).I've basically rewritten the entire thing, but each commit should be a logical step (they were the steps I took while porting).
There are some TODO's in some of the commits.
Evaluation on
js/sql-injectionlooks fine.(Internal: I'm using this PR to test a
dcafeature, ignore the backrefs).