Data flow: Add tests for missing summary flow #6841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
dataflow/incorrect-summary-chaining
branch
from
722eac9 to
68ea3e7
Compare
aschackmull
reviewed
Oct 12, 2021
csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImpl.qll
Outdated
Show resolved
Hide resolved
aschackmull
reviewed
Oct 12, 2021
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>
aschackmull
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first two commits add (identical) C# and Java tests that show we are missing some flow through summarized callables. The details why we are missing the flow are quite involved, but it happens because we recently introduced derived flow steps inside summarized callables.
The third commit adds debugging functionality for visualizing the data flow graph for summarized callables, which is quite handy for understanding why we are missing flow. In combination with github/vscode-codeql#705, this allows us to render graphs like
Adding the missing flow will be done in follow-up work.