Skip to content

Java: Serialization query improvements #6849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 12, 2021
Merged

Java: Serialization query improvements #6849

merged 5 commits into from
Oct 12, 2021

Conversation

Marcono1234
Copy link
Contributor

Changes which hopefully improve the queries for standard Java serialization; and also one commit for an annotation query.

@Marcono1234 Marcono1234 requested a review from a team as a code owner October 10, 2021 23:51
@Marcono1234 Marcono1234 force-pushed the marcono1234/improvements branch from 6cb46be to a7670fb Compare October 11, 2021 00:06
atorralba
atorralba reviewed Oct 11, 2021
View reviewed changes
Copy link
Contributor

@atorralba atorralba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, most of these look like good code quality improvements. I added a couple of inline comments.

@Marcono1234
Copy link
Contributor Author

I have changed IncorrectSerializableMethods.ql now to:

  • check fromSource() to avoid reporting methods of parameterized types (can be seen with hibernate/hibernate-orm)
  • provide more information in query result message

@aschackmull aschackmull added the no-change-note-required This PR does not need a change note label Oct 12, 2021
@aschackmull aschackmull merged commit 6b4ca31 into github:main Oct 12, 2021
@Marcono1234 Marcono1234 deleted the marcono1234/improvements branch October 12, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschackmull aschackmull aschackmull approved these changes

+1 more reviewer

@atorralba atorralba atorralba left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation Java no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Marcono1234 @atorralba @aschackmull