C++/C#/JS/Python: Replace 'if p() then q() else none()' with a conjunction #6865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschackmull
previously requested changes
Oct 13, 2021
MathiasVP
force-pushed
the
fix-if-none
branch
from
2390883 to
bdc54bc
Compare
MathiasVP
changed the title
|
I've removed the results that @aschackmull didn't like and force-pushed the new changes. |
erik-krogh
approved these changes
Oct 13, 2021
geoffw0
approved these changes
Oct 13, 2021
tausbn
approved these changes
Oct 13, 2021
|
@MathiasVP dismissed @aschackmull's review as his requested changes have been applied |
Thanks a lot! Since all the C# changes are in code related to the IR I'll merge this without waiting on their explicit approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pattern
if p() then q() else none()is equivalent top() and q(). Likewise, the patternif p() then none() else q()is equivalent tonot p() and q().