Skip to content

more instanceof extensions #6866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 13, 2021
Merged

more instanceof extensions #6866

merged 6 commits into from
Oct 13, 2021

Conversation

ginsbach
Copy link
Contributor

@ginsbach ginsbach commented Oct 13, 2021

The ql-on-ql hackathon surfaced some more opportunities for non-extending subtypes: https://github.com/github/codeql-ql/issues/45

This PR implements a handful of them.

@ginsbach ginsbach requested review from a team as code owners October 13, 2021 10:48
@ginsbach ginsbach requested a review from erik-krogh October 13, 2021 10:48
@ginsbach ginsbach added the no-change-note-required This PR does not need a change note label Oct 13, 2021
hvitved
hvitved previously approved these changes Oct 13, 2021
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C# 👍

erik-krogh
erik-krogh previously approved these changes Oct 13, 2021
MathiasVP
MathiasVP previously approved these changes Oct 13, 2021
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++ 👍

@ginsbach ginsbach dismissed stale reviews from MathiasVP, erik-krogh, and hvitved via c9c0c7f October 13, 2021 12:10
@ginsbach ginsbach merged commit a204b7f into main Oct 13, 2021
@ginsbach ginsbach deleted the ginsbach/MoreInstanceofExtensions branch October 13, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# C++ no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants